> On Dec. 16, 2013, 7:41 p.m., Ben Mahler wrote: > > src/master/master.cpp, line 689 > > <https://reviews.apache.org/r/16290/diff/1/?file=398158#file398158line689> > > > > This seems like an unexpected failure than an expected event so I would > > use LOG(FATAL) here. Is my understanding correct here? > > Ben Mahler wrote: > The con of using LOG(FATAL) in this case is that we do not need the stack > trace, and I suspect misconfiguration could actually cause these failures, in > which case, EXIT(1) seems more appropriate. So I think I take back my comment > here, thoughts? > > Jiang Yan Xu wrote: > I lean towards using EXIT(1).
They are arguments both ways but I guess "expected" is more subjective while "need stack trace" is easier to determine so maybe we'll use it to judge between the two. We can put it in our coding conventions. - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16290/#review30463 ----------------------------------------------------------- On Dec. 16, 2013, 10:08 a.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16290/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2013, 10:08 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-883 > https://issues.apache.org/jira/browse/MESOS-883 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/master.cpp dd6111946289b82008a66e46df8ef5e538de70ea > src/sched/sched.cpp c46535643ce2ea456bd939571fe78358c1d3871b > src/slave/slave.cpp 6e6107e3551f29566ff233dad47dac8c29b4fab5 > src/tests/master_contender_detector_tests.cpp > 76464eab479461e6e3cb8b5afe85860e60428cf5 > src/tests/zookeeper_tests.cpp a0660cbfb1b7073654b05b82bffd69fbb04d0165 > src/zookeeper/contender.hpp d0b386eeec485f7c8e6b5e60936a84d2f0bba92d > src/zookeeper/contender.cpp bb7e25555b2635398e9d56a808993bcd0b0e47f6 > src/zookeeper/group.hpp 088363a80108472ffeb14121fcb4da02d6e9acf4 > src/zookeeper/group.cpp f3ba86fec3584a83fd55d6388656ebde5249824a > > Diff: https://reviews.apache.org/r/16290/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jiang Yan Xu > >
