----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16395/ -----------------------------------------------------------
Review request for mesos. Repository: mesos-git Description ------- Moved control of navbar tabs to MainController This removes another dependency on jQuery and lets the MainController control its tabs. `setNavbarActiveTab` was a global function that was accessing the global DOM, which meant the controllers were editing things they didn't control. The MainController now sets the tab based on the path. We are almost to zero jQuery... Diffs ----- src/webui/master/static/index.html 1ac7c9dff91a82c296ac8a58f77b490f4e9d7f6a src/webui/master/static/js/controllers.js c7042cac3ac406ede5a529e173084451f54f0462 Diff: https://reviews.apache.org/r/16395/diff/ Testing ------- Thanks, Ross Allen
