----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16238/#review30712 -----------------------------------------------------------
Ship it! src/tests/slave_recovery_tests.cpp <https://reviews.apache.org/r/16238/#comment58809> Indentation? - Benjamin Hindman On Dec. 18, 2013, 2:16 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16238/ > ----------------------------------------------------------- > > (Updated Dec. 18, 2013, 2:16 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Bugs: MESOS-844 > https://issues.apache.org/jira/browse/MESOS-844 > > > Repository: mesos-git > > > Description > ------- > > See MESOS-844. This uses the boot id to check whether the underlying machine > has rebooted. If so, we do not want to attempt recovery given the PIDs are > stale and machine information may have changed. > > > Diffs > ----- > > src/slave/paths.hpp 8f80b931a896cd7e317658147e864410558d5028 > src/slave/slave.cpp 6e6107e3551f29566ff233dad47dac8c29b4fab5 > src/slave/state.cpp bf267b5ea23a7427c7cb05ab4e98af2e44d9cc43 > src/tests/slave_recovery_tests.cpp 250083d380bf6d0bdba09abd239a9139a402008f > > Diff: https://reviews.apache.org/r/16238/diff/ > > > Testing > ------- > > Added an integration test, make check. > > > Thanks, > > Ben Mahler > >
