----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16291/#review30716 -----------------------------------------------------------
Ship it! Ship It! - Ben Mahler On Dec. 19, 2013, 7:57 a.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16291/ > ----------------------------------------------------------- > > (Updated Dec. 19, 2013, 7:57 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-883 > https://issues.apache.org/jira/browse/MESOS-883 > > > Repository: mesos-git > > > Description > ------- > > Now that local session timeouts are transparent to the clients of the master > detector, they are not supposed to retry anymore. Thus passing "Result<UPID> > previous" back into MasterDetector::detect() is no longer correct. > > > Diffs > ----- > > src/cli/resolve.cpp dddadfc2bff41752372e0e817beb0493cd0cd127 > src/master/detector.hpp 6e7a4c42c8a1dcfe95b2244213013d3f0aff311a > src/master/detector.cpp 2f73f669f0b3a8dccbce9fdfa941593314302171 > src/master/master.hpp 6c168a2cdbd8343516cb47adceaff70c3d46690b > src/master/master.cpp dd6111946289b82008a66e46df8ef5e538de70ea > src/sched/sched.cpp c46535643ce2ea456bd939571fe78358c1d3871b > src/slave/slave.hpp 71fa4f0d0ccde8cdc023b18c6a4d7eb7478fd0cf > src/slave/slave.cpp 6e6107e3551f29566ff233dad47dac8c29b4fab5 > src/tests/master_contender_detector_tests.cpp > 76464eab479461e6e3cb8b5afe85860e60428cf5 > src/tests/zookeeper_tests.cpp a0660cbfb1b7073654b05b82bffd69fbb04d0165 > src/zookeeper/detector.hpp de4acab422e2fa4b7420f44b4e8ebc941f91f200 > src/zookeeper/detector.cpp 1de3663ecaed6d8c362c20a5a46d2f4d73f8fbd0 > > Diff: https://reviews.apache.org/r/16291/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jiang Yan Xu > >
