> On Jan. 6, 2014, 7:25 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, line 888 > > <https://reviews.apache.org/r/16569/diff/4/?file=413787#file413787line888> > > > > If we're making total and free memory two separate function calls, > > os::totalMemory and os::freeMemory seems more consistent. > > > > But, what about a single os::memory that returns a simple os::Memory > > struct, rather than making two separate functions?
+1! - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16569/#review31245 ----------------------------------------------------------- On Jan. 2, 2014, 11:04 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16569/ > ----------------------------------------------------------- > > (Updated Jan. 2, 2014, 11:04 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > freeMemory() returns amount of free system memory. Can in > combination with memory() be used to get total used memory. > This allows future finer grained break-downs of used memory > in user memory, kernel buffers/caches and so on. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 7c1f6ec > > Diff: https://reviews.apache.org/r/16569/diff/ > > > Testing > ------- > > make check and functional testing. > > > Thanks, > > Niklas Nielsen > >
