[
https://issues.apache.org/jira/browse/MESOS-895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13864472#comment-13864472
]
Timothy St. Clair commented on MESOS-895:
-----------------------------------------
Re: wrapper -
<schmorp> tstclair: for example, urxvt has a ev_cpp.h file which defines stuff
and includes ev++.h
<schmorp> tstclair: and a ev_cpp.C file, which defines a bunch and includes ev.c
<schmorp> tstclair: urxvt then uses ev_cpp.h as header, and ev_cpp.C as
implementation, ignoring the other libev files
<schmorp> tstclair: (while compiling)
re: CFLAGS -
That is the packagers responsibility to detect & maintain.
Arguably offloading mesos-upstream should be a primary goal if possible (less
to maintain).
> Removal of libev patch
> ----------------------
>
> Key: MESOS-895
> URL: https://issues.apache.org/jira/browse/MESOS-895
> Project: Mesos
> Issue Type: Bug
> Components: build
> Affects Versions: 0.17.0
> Reporter: Timothy St. Clair
>
> The libev patch can easily be removed and update the configuration flags and
> possibly the accompanying code prior to include.
> For configure pass in:
> CFLAGS=-DEV_CHILD_ENABLE=0
> For inclusion:
> #define EV_CHILD_ENABLE 0
> include <ev.h>
> excerpt from maintainer:
> <schmorp> that patch is unnecessary
> <tstclair> schmorp, so if they wanted to just set EV_CHILD_ENABLE=0 they
> could just pass CFLAGS=-DEV_CHILD_ENABLE=0 through.
> <schmorp> tstclair: yes, or use a wrapper
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
