----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16713/#review31450 -----------------------------------------------------------
Ship it! Ship It! - Ben Mahler On Jan. 8, 2014, 12:34 a.m., Ross Allen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16713/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2014, 12:34 a.m.) > > > Review request for mesos. > > > Repository: mesos-git > > > Description > ------- > > Moved columnClass and selectColumn to Table prototype. > > This prevents having to expose global functions to every local scope. > This also simplifies the functions since they now live on the same > prototype as the columns they are trying to edit. They can use `this` > correctly. > > > Diffs > ----- > > src/webui/master/static/framework.html > 7dc620509829125a487ed1021638ae5a10ed62e0 > src/webui/master/static/frameworks.html > f83cffea5fb5f32c4a4690d7548aa784a6d21e67 > src/webui/master/static/home.html cd2ec75901466f6fddee5668abf893f0aaaae717 > src/webui/master/static/js/controllers.js > 1ba84f1716419cd6a8f6607295a3a061323e10f9 > src/webui/master/static/offers.html > 215d65e1ad30fb0df06bcf05cec797d60672ec66 > src/webui/master/static/slave.html 24e855b8c8b172bf5dec0ba51a22d94cdb0aa257 > src/webui/master/static/slave_executor.html > 519847c0de077717c88c4d35804ad40d339d4246 > src/webui/master/static/slave_framework.html > 947bab12eec8c3be5c3893b873b4b6378c8dcbbb > src/webui/master/static/slaves.html > ee41b26cbe34117aa80ace90529e5bc67e91f2e7 > > Diff: https://reviews.apache.org/r/16713/diff/ > > > Testing > ------- > > > Thanks, > > Ross Allen > >
