> On Jan. 9, 2014, 9:28 p.m., Benjamin Hindman wrote: > > src/webui/master/static/js/controllers.js, line 184 > > <https://reviews.apache.org/r/16715/diff/3/?file=418333#file418333line184> > > > > Is 'setTaskStatus' the right name here? Factoring this code out looks > > great but the name seems a bit weird (it appears to actually be setting the > > task's executor ID and start/finish time, not setting it's TaskStatus).
Good point, I forgot that status was already in use for something else. - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16715/#review31461 ----------------------------------------------------------- On Jan. 8, 2014, 1:51 a.m., Thomas Rampelberg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16715/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2014, 1:51 a.m.) > > > Review request for mesos and Ross Allen. > > > Repository: mesos-git > > > Description > ------- > > showing start/stop time for tasks of completed frameworks > > Review: http://reviews.apache.org/r/16715 > > > Diffs > ----- > > src/webui/master/static/js/controllers.js > 1ba84f1716419cd6a8f6607295a3a061323e10f9 > > Diff: https://reviews.apache.org/r/16715/diff/ > > > Testing > ------- > > > Thanks, > > Thomas Rampelberg > >
