----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16655/#review31543 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/include/process/c++11/defer.hpp <https://reviews.apache.org/r/16655/#comment60074> one day.. :( 3rdparty/libprocess/include/process/c++11/deferred.hpp <https://reviews.apache.org/r/16655/#comment60075> I'm not sure we gain from using auto here and throughout the similar code below. The explicit types: UPID pid_ = pid.get(); F f_ = f; are actually more succinct than auto in this case. 3rdparty/libprocess/include/process/c++11/dispatch.hpp <https://reviews.apache.org/r/16655/#comment60078> whitespace 3rdparty/libprocess/include/process/c++11/executor.hpp <https://reviews.apache.org/r/16655/#comment60076> Why the & on these? 'terminate' and 'wait' can take references as well. 3rdparty/libprocess/include/process/defer.hpp <https://reviews.apache.org/r/16655/#comment60070> These make me think a C++11 block is being closed, but it's the closing the 'else' (< C++11) block. These are scattered across a few changes so not sure if you want to go through the effort of updating all of them. - Ben Mahler On Jan. 6, 2014, 7:40 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16655/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2014, 7:40 p.m.) > > > Review request for mesos, Ben Mahler, Niklas Nielsen, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Some fixes and enhancements were also made to the C++11 version of the > library. At this point libprocess can be compiled for C++11 and all tests > pass with gcc 4.8. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/async.hpp > 8fa2771e049922bcac20e2ed39dab221c6bedc1e > 3rdparty/libprocess/include/process/c++11/defer.hpp PRE-CREATION > 3rdparty/libprocess/include/process/c++11/deferred.hpp PRE-CREATION > 3rdparty/libprocess/include/process/c++11/delay.hpp PRE-CREATION > 3rdparty/libprocess/include/process/c++11/dispatch.hpp PRE-CREATION > 3rdparty/libprocess/include/process/c++11/executor.hpp PRE-CREATION > 3rdparty/libprocess/include/process/collect.hpp > 27e27299bf54c9be55240bee01476d06c530631d > 3rdparty/libprocess/include/process/defer.hpp > 1eb770b12123e7b893e08438bfb296254c2e6dca > 3rdparty/libprocess/include/process/deferred.hpp > 8907e80570093baa03b2c7a3dd0e08b421fa6a99 > 3rdparty/libprocess/include/process/delay.hpp > 97acd76625337424f7a0fdc9ee6d8dcf04ac78eb > 3rdparty/libprocess/include/process/dispatch.hpp > b337a87efff58c7a853a3759cffd368677673e24 > 3rdparty/libprocess/include/process/event.hpp > cf728dafc7a5ec7bd3c7ab6fe46f54b41777aa81 > 3rdparty/libprocess/include/process/executor.hpp > f203476208b18108880ce487860529b5aba3f256 > 3rdparty/libprocess/include/process/future.hpp > 4122b96ed82105f8ddcbae8904281864ca480c82 > 3rdparty/libprocess/include/process/gmock.hpp > a8cab4c5bab689dfa10b8bd5c997ac6e1df56d24 > 3rdparty/libprocess/include/process/process.hpp > d9dc57196ec810804ed492cfb2f9a9a5819f9de4 > 3rdparty/libprocess/include/process/protobuf.hpp > 5a6fc83e7c12696d86f10cb2a6e12a4a338db299 > 3rdparty/libprocess/include/process/run.hpp > a245b7094c934ff1c93a33b0bcbe2445a6b0b637 > 3rdparty/libprocess/include/process/timer.hpp > 333a80610fec20c83e923fdbb49fbae490c6ff33 > 3rdparty/libprocess/src/process.cpp > 2d193b13cde92a061b02f903a5d6471ff90cb12a > 3rdparty/libprocess/src/tests/process_tests.cpp > b0fb5c2401618d83c95b9b87f1f5dc107c4ad466 > 3rdparty/libprocess/src/timer.cpp 63c5ac1bbd06dd2be57bbc2bd81cbd93b53afad2 > > Diff: https://reviews.apache.org/r/16655/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
