----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16663/#review31561 -----------------------------------------------------------
Ship it! - Ben Mahler On Jan. 6, 2014, 7:40 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16663/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2014, 7:40 p.m.) > > > Review request for mesos, Ben Mahler, Niklas Nielsen, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > When building with clang we assume --with-cxx11. For example: > > CC=/path/to/clang CXX=/path/to/clang++ ../configure > > But when building with gcc 4.8 you need to specify C++11: > > CC=/path/to/gcc CXX=/path/to/g++ ../configure --with-cxx11 > > > Diffs > ----- > > 3rdparty/libprocess/configure.ac d3b86a3d6360d146fda1789ed479f8c5acd6e8fd > 3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4 PRE-CREATION > > Diff: https://reviews.apache.org/r/16663/diff/ > > > Testing > ------- > > $ CC=/path/to/clang CXX=/path/to/clang++ ../configure && make check > $ CC=/path/to/gcc CXX=/path/to/g++ ../configure --with-cxx11 && make check > > > Thanks, > > Benjamin Hindman > >
