----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16657/#review31631 -----------------------------------------------------------
Ship it! src/jvm/jvm.hpp <https://reviews.apache.org/r/16657/#comment60318> Do you need a copy here? It looks like setField will make a copy. src/tests/zookeeper.cpp <https://reviews.apache.org/r/16657/#comment60320> Why all the std:: prefixes in this cpp file? src/tests/zookeeper_test_server.cpp <https://reviews.apache.org/r/16657/#comment60321> We should probably mention that this hack is for 3.4.5. - Ben Mahler On Jan. 6, 2014, 7:40 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16657/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2014, 7:40 p.m.) > > > Review request for mesos, Ben Mahler, Niklas Nielsen, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > In order to build Mesos with clang we need to upgrade ZooKeeper. > Unfortunately, Mesos leveraged some internal APIs of ZooKeeper that changed > so this commit required some refactorings. > > > Diffs > ----- > > 3rdparty/versions.am 5932e1fa43d8d0b9a9ea9e46431e2c8dbcb9aea6 > 3rdparty/zookeeper-3.3.4.tar.gz 09d49240fb76e77244c88233ffff1a19f4108690 > src/Makefile.am 054ba2e9bd3935ca354b62ecb2a833fc021aec9d > src/jvm/jvm.hpp a3ea86a33097752e359fa327a7ea3d73b378bd63 > src/jvm/jvm.cpp 17ab12efee22e9285f6628b2de35ceb258db583b > src/jvm/org/apache/log4j.hpp 6b5ba4b162196966f2646e046b433edaba2125cf > src/jvm/org/apache/log4j.cpp b73df8c294b3d250aeddb3295a45a13984efcd1d > src/jvm/org/apache/zookeeper.hpp 2b78a254e442afa1fbd157a745f8a3a0567a1898 > src/jvm/org/apache/zookeeper.cpp PRE-CREATION > src/python/setup.py.in 77fa880a16f1c8ccecb7bb0db3cfea75413b104a > src/tests/zookeeper.cpp 8bb49012d8dc46ef9f5a64ead1654253b9df8c21 > src/tests/zookeeper_test_server.hpp > e6126215f6b6fd3277ae0a4371c05d898d6114ce > src/tests/zookeeper_test_server.cpp > 62b4e0bab5b5500df0297959ca99c569a8811ce4 > > Diff: https://reviews.apache.org/r/16657/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
