----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16634/#review31646 -----------------------------------------------------------
src/master/http.cpp <https://reviews.apache.org/r/16634/#comment60329> We should suffix these names with the unit of measurement, e.g.: system_mem_total_bytes - Ben Mahler On Jan. 9, 2014, 11:46 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16634/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2014, 11:46 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-581 > https://issues.apache.org/jira/browse/MESOS-581 > > > Repository: mesos-git > > > Description > ------- > > This patch expose the number bytes of total and free memory in the > master and slave stats endpoints. > Similar to https://reviews.apache.org/r/16631/, the new fields are > named system_mem_total and system_mem_free to disambiguate the > aggregate mem_total, mem_used, ... in the master stats endpoint. > Again, I am open to another naming scheme. > > > Diffs > ----- > > src/master/http.cpp d7cd89f > src/slave/http.cpp 1358810 > > Diff: https://reviews.apache.org/r/16634/diff/ > > > Testing > ------- > > make check and functional testing of /stats.json endpoints. > > > Thanks, > > Niklas Nielsen > >
