> On Jan. 13, 2014, 9:48 a.m., Vinod Kone wrote:
> > src/master/master.hpp, lines 178-181
> > <https://reviews.apache.org/r/16742/diff/1/?file=419176#file419176line178>
> >
> >     Doesn't look like these two needed to be pulled up?

Right, but just thought these three were of similar nature and sort of a 
*group*.


> On Jan. 13, 2014, 9:48 a.m., Vinod Kone wrote:
> > src/tests/mesos.cpp, lines 85-88
> > <https://reviews.apache.org/r/16742/diff/1/?file=419177#file419177line85>
> >
> >     Why did you have to do this? It doesn't seem to describe what this 
> > method is doing.

It's described in https://issues.apache.org/jira/browse/MESOS-881, without it 
sometimes the method returns with the master not knowing (it is) the leader and 
rejects authentication requests and prolongs the test duration.


- Jiang Yan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16742/#review31621
-----------------------------------------------------------


On Jan. 8, 2014, 5:03 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16742/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2014, 5:03 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-881
>     https://issues.apache.org/jira/browse/MESOS-881
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 95b9cecd6f9ea0afb3f7f9753a3a06c0c8d8f9d4 
>   src/tests/mesos.cpp 5359394f45475803e05d281710139e8cbe7c7364 
> 
> Diff: https://reviews.apache.org/r/16742/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Reply via email to