Re: Review Request 16589: ZooKeeperMasterContenderProcess::contend now checks if the future for the previous contend() is still pending and if so it directly returns that future without recontending.

[Vinod Kone]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16589/#review31763
-----------------------------------------------------------

Ship it!


Is there a test for this?


src/master/contender.hpp
<https://reviews.apache.org/r/16589/#comment60488>

    s/Recontending/Recontending after candidacy is obtained/ ?



src/master/contender.cpp
<https://reviews.apache.org/r/16589/#comment60489>

    new line.


- Vinod Kone


On Jan. 3, 2014, 11:36 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16589/
> -----------------------------------------------------------
> 
> (Updated Jan. 3, 2014, 11:36 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-892
>     https://issues.apache.org/jira/browse/MESOS-892
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/contender.hpp 7764edd037fef3590694098397483b1b19c5cda2 
>   src/master/contender.cpp 84b0552a1375726d9a2fd6213b49e13f49027c3d 
> 
> Diff: https://reviews.apache.org/r/16589/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>