----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16591/#review31789 -----------------------------------------------------------
Ship it! src/zookeeper/group.cpp <https://reviews.apache.org/r/16591/#comment60513> How about foreachvalue(Promise<bool>* cancelled, owned) { cancelled->set(false); delete canceled. } owned.clear(); This would avoid making a copy of owned. - Vinod Kone On Jan. 3, 2014, 10:46 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16591/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2014, 10:46 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/zookeeper/group.cpp 47d599dd180bb3db839edd6a9510b9d90984119f > > Diff: https://reviews.apache.org/r/16591/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jiang Yan Xu > >
