-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16839/
-----------------------------------------------------------
(Updated Jan. 15, 2014, 2:05 a.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, Jeff Currier, and Jie
Yu.
Changes
-------
Incorporate CR feedback.
Renamed internal::httpRequest to just be internal::request.
Changed internal::request to take Option<string> so that None
indicates no body instead of empty string.
Summary (updated)
-----------------
Incorporate CR feedback.
Bugs: https://issues.apache.org/jira/browse/MESOS-902
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/MESOS-902
Repository: mesos-git
Description
-------
Add post function to http.hpp of libprocess.
This adds the post equivalent of the get function to http.hpp.
The existing get method is refactored into internal::httpRequest
with arguments for method, query, and body.
The get and post functions can then be implemented as simple
wrapper of internal::httpRequest.
There are also new unit tests to verify the existing behavior of
get and the new post behavior.
See: https://issues.apache.org/jira/browse/MESOS-902
Review: https://reviews.apache.org/r/16839
Diffs (updated)
-----
3rdparty/libprocess/include/process/http.hpp
5bdd520c9e0bcc0a2d3a4554cc4ced99dcf78b51
3rdparty/libprocess/src/process.cpp 67f7f9b3b05c8bc9b0f6281689223996ddfa68d1
3rdparty/libprocess/src/tests/http_tests.cpp
68d1a1b2ed5645d861b1e613aed9731368ebdc6a
Diff: https://reviews.apache.org/r/16839/diff/
Testing
-------
added new unit tests
make check
Thanks,
Charlie Carson
