> On Jan. 14, 2014, 7:40 p.m., Jie Yu wrote: > > 3rdparty/libprocess/src/process.cpp, line 3622 > > <https://reviews.apache.org/r/16839/diff/1/?file=422273#file422273line3622> > > > > Also, consider moving all http related functions to src/http.cpp > > Jie Yu wrote: > Well, if there exist some dependencies that make it non-trivial, maybe > just leave it as it is. > > Charlie Carson wrote: > I'll do a quick test and see if that works. process.cpp is definitely > large, so it would be good to break it up if possible.
that does work but I want to send a separate review for that change since it involves both new and existing code moving. I'll do that as soon as this one is accepted into master. - Charlie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16839/#review31774 ----------------------------------------------------------- On Jan. 15, 2014, 2:05 a.m., Charlie Carson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16839/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2014, 2:05 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Jeff Currier, and Jie > Yu. > > > Bugs: https://issues.apache.org/jira/browse/MESOS-902 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/MESOS-902 > > > Repository: mesos-git > > > Description > ------- > > Add post function to http.hpp of libprocess. > > This adds the post equivalent of the get function to http.hpp. > > The existing get method is refactored into internal::httpRequest > with arguments for method, query, and body. > > The get and post functions can then be implemented as simple > wrapper of internal::httpRequest. > > There are also new unit tests to verify the existing behavior of > get and the new post behavior. > > See: https://issues.apache.org/jira/browse/MESOS-902 > > Review: https://reviews.apache.org/r/16839 > > > Diffs > ----- > > 3rdparty/libprocess/include/process/http.hpp > 5bdd520c9e0bcc0a2d3a4554cc4ced99dcf78b51 > 3rdparty/libprocess/src/process.cpp > 67f7f9b3b05c8bc9b0f6281689223996ddfa68d1 > 3rdparty/libprocess/src/tests/http_tests.cpp > 68d1a1b2ed5645d861b1e613aed9731368ebdc6a > > Diff: https://reviews.apache.org/r/16839/diff/ > > > Testing > ------- > > added new unit tests > make check > > > Thanks, > > Charlie Carson > >
