----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16065/#review31942 -----------------------------------------------------------
Ship it! src/log/consensus.cpp <https://reviews.apache.org/r/16065/#comment60696> I think 'timeout' here is ambiguous. The operation will just "hang" and the code waiting on the future will either wait forever or they're own timeout mechanism will occur which discards the future thus canceling the watch. src/log/consensus.cpp <https://reviews.apache.org/r/16065/#comment60695> Let's remember that we want to move away from these CHECK semantics and move to properly handling discarded futures. src/log/consensus.cpp <https://reviews.apache.org/r/16065/#comment60698> Maybe Network::watch could take a 'mode' enum which describes how you want to watch the network? For example, one mode could be for equals, one mode could be for less than, less than or equal, greater than, greater than or equal, etc, and then you could really simply this code here. - Benjamin Hindman On Dec. 6, 2013, 12:33 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16065/ > ----------------------------------------------------------- > > (Updated Dec. 6, 2013, 12:33 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Jiang Yan Xu. > > > Bugs: MESOS-736 > https://issues.apache.org/jira/browse/MESOS-736 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/log/consensus.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/16065/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
