----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14940/#review31949 -----------------------------------------------------------
3rdparty/libprocess/include/process/help.hpp <https://reviews.apache.org/r/14940/#comment60712> Shoot, looks like this doesn't work for the slaves, since hitting /help on the slave will attempt to load this master-only script. Since /help is for any libprocess binary, we should figure out how to make this work in the general case. Filed: https://issues.apache.org/jira/browse/MESOS-913 - Ben Mahler On Nov. 1, 2013, 6:08 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14940/ > ----------------------------------------------------------- > > (Updated Nov. 1, 2013, 6:08 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Repository: mesos-git > > > Description > ------- > > Using api.github.com for mark-down rendering limits off-line use and cause > trouble with help is excessively used on a shared IP due to api quota rules. > > This patch includes Christopher Jeffrey's Marked mark-down compiler > (https://github.com/chjj/marked) and replaces the github api call. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/help.hpp 65b0590 > src/Makefile.am a11c76b > src/webui/master/static/js/marked.min.js PRE-CREATION > > Diff: https://reviews.apache.org/r/14940/diff/ > > > Testing > ------- > > make check > > And functional testing of /help endpoints. > > > Thanks, > > Niklas Nielsen > >
