> On Jan. 10, 2014, 8:43 p.m., Ben Mahler wrote: > > include/mesos/mesos.proto, line 141 > > <https://reviews.apache.org/r/15542/diff/9/?file=412606#file412606line141> > > > > I was wrong about marking this as deprecated, it still seems useful for > > frameworks that want the shell to search for binaries on the PATH. > > > > Can you kill the comment here? > > Jason Dusek wrote: > But execvp searches for binaries on the path, too.
Although searching for binaries on the path might not be a case where the shell is valuable, the similar use case of using globbing to deal with distro tarballs is. However, in this case, people can use `["sh", "-c", "cd hadoop-*/ && bin/hadoop"]`. What is being deprecated is the implicit shell semantics -- let them be explicit instead. It seems wrong to bake shell semantics in to Mesos -- surely implicit shell magic is not the way of the future? - Jason ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15542/#review31536 ----------------------------------------------------------- On Jan. 17, 2014, 5:54 a.m., Jason Dusek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15542/ > ----------------------------------------------------------- > > (Updated Jan. 17, 2014, 5:54 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > Offer an execvp like interface for running tasks. > > Review: https://reviews.apache.org/r/15542 > > > Diffs > ----- > > include/mesos/mesos.proto 655f86757487ddbe551fdcf53eb793e773ecdd34 > src/examples/python/test_framework.py > deca48e779ae099424fa73bb9a8ac5c419c5faf1 > src/launcher/executor.cpp b73ab479500a7347a38ba53acecfab9229f1080d > src/launcher/launcher.cpp d5ab66704429a95eeb8eda5188e33d8e691221af > src/launcher/main.cpp de64609905ee63096c0173fe7e64a1eafea5d6bf > src/slave/process_isolator.cpp 0bc698f04f7c8eaad166dc9d646e13310129dd01 > > Diff: https://reviews.apache.org/r/15542/diff/ > > > Testing > ------- > > Ran Python test executor and `make check`. > > > Thanks, > > Jason Dusek > >
