> On Jan. 16, 2014, 1:32 a.m., Benjamin Hindman wrote: > > This looks good Tim and after you make those small cleanups we'll get it > > committed. I agree that as a header only library we shouldn't have HAVE_* > > in the code. That being said, committing this will likely break some of the > > Jenkins builds of Mesos out there that don't have libcurl installed (for > > example, the Jenkins provided at Apache don't have libcurl). Are there some > > followup changes that conditionally include this in libprocess/Mesos > > depending on the system libraries? Or do you have another suggestion? We > > can likely get libcurl installed on the Jenkins machines at Apache if you > > didn't have anything planned (and we should probably be testing all of our > > code there anyway). > > Benjamin Hindman wrote: > Jake Farrell updated the Jenkins machines so we can get this committed. > It probably makes sense to either remove the --without-curl option from the > libprocess/Mesos configure.ac or update those projects to not use the headers > if specified (versus doing it in the headers, which was wrong). Thoughts? > > Timothy St. Clair wrote: > Typically projects will isolate and wrap dependencies using a config.h > file which is dropped and checked in the .cpp files. Selectively enabling > features where possible, or hard failing on configure where the feature is > fundamental. When all else fails define layers of pluggable support where it > makes sense.
Great, this is submitted, thanks Tim. Yes, can you open a new ticket re: --with(out)-curl too? Thanks! - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16830/#review31985 ----------------------------------------------------------- On Jan. 16, 2014, 4:31 p.m., Timothy St. Clair wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16830/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2014, 4:31 p.m.) > > > Review request for mesos and Timothy St. Clair. > > > Bugs: MESOS-897 > https://issues.apache.org/jira/browse/MESOS-897 > > > Repository: mesos-git > > > Description > ------- > > Update to stout headers from reviews. > - Adding apache blocks > - Remove HAVE_ from direct headers, configure.ac deps are hard. (also not > allowed in header only libraries) > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/bytes.hpp 754fbb2 > 3rdparty/libprocess/3rdparty/stout/include/stout/cache.hpp 653507c > 3rdparty/libprocess/3rdparty/stout/include/stout/check.hpp eb31841 > 3rdparty/libprocess/3rdparty/stout/include/stout/duration.hpp 2f5a93e > 3rdparty/libprocess/3rdparty/stout/include/stout/error.hpp 97a5cec > 3rdparty/libprocess/3rdparty/stout/include/stout/exit.hpp e8da726 > 3rdparty/libprocess/3rdparty/stout/include/stout/fatal.hpp eabee3e > 3rdparty/libprocess/3rdparty/stout/include/stout/flags.hpp a70db19 > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp 2ba739d > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 0d3c836 > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/loader.hpp a6e0f58 > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp 4c5b297 > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/stringifier.hpp > 669218c > 3rdparty/libprocess/3rdparty/stout/include/stout/foreach.hpp 0afe285 > 3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp cae7fcb > 3rdparty/libprocess/3rdparty/stout/include/stout/fs.hpp 3a20e86 > 3rdparty/libprocess/3rdparty/stout/include/stout/gtest.hpp 1f10834 > 3rdparty/libprocess/3rdparty/stout/include/stout/gzip.hpp ef36f1b > 3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp dc78e28 > 3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp f1f2099 > 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 4406d07 > 3rdparty/libprocess/3rdparty/stout/include/stout/lambda.hpp d493353 > 3rdparty/libprocess/3rdparty/stout/include/stout/linkedhashmap.hpp a27ec26 > 3rdparty/libprocess/3rdparty/stout/include/stout/multihashmap.hpp 10e49dc > 3rdparty/libprocess/3rdparty/stout/include/stout/multimap.hpp 187ad79 > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 1c5f88a > 3rdparty/libprocess/3rdparty/stout/include/stout/none.hpp ea8e0f5 > 3rdparty/libprocess/3rdparty/stout/include/stout/nothing.hpp c11a010 > 3rdparty/libprocess/3rdparty/stout/include/stout/numify.hpp d23e238 > 3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 89b7fc3 > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 2c4ddb0 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/exists.hpp 0b30dbe > 3rdparty/libprocess/3rdparty/stout/include/stout/os/fork.hpp 838a5fe > 3rdparty/libprocess/3rdparty/stout/include/stout/os/killtree.hpp 25e9937 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp 25d5903 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/ls.hpp 7637a0d > 3rdparty/libprocess/3rdparty/stout/include/stout/os/osx.hpp 7d02566 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/process.hpp d754601 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/pstree.hpp 4637e68 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp 587b7b9 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/sendfile.hpp 668e4da > 3rdparty/libprocess/3rdparty/stout/include/stout/os/signals.hpp 215ee55 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp 05b0678 > 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp fda4e04 > 3rdparty/libprocess/3rdparty/stout/include/stout/preprocessor.hpp 466e16f > 3rdparty/libprocess/3rdparty/stout/include/stout/proc.hpp c3eac30 > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 3fa7fe6 > 3rdparty/libprocess/3rdparty/stout/include/stout/result.hpp f918f86 > 3rdparty/libprocess/3rdparty/stout/include/stout/set.hpp ba7ffe8 > 3rdparty/libprocess/3rdparty/stout/include/stout/some.hpp e2f56cc > 3rdparty/libprocess/3rdparty/stout/include/stout/stopwatch.hpp 97e3469 > 3rdparty/libprocess/3rdparty/stout/include/stout/stringify.hpp 2bb7290 > 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp 46a0a26 > 3rdparty/libprocess/3rdparty/stout/include/stout/thread.hpp c5dbe79 > 3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp 787bffd > 3rdparty/libprocess/3rdparty/stout/include/stout/utils.hpp 0f4bba2 > 3rdparty/libprocess/3rdparty/stout/include/stout/uuid.hpp c6c290d > > Diff: https://reviews.apache.org/r/16830/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy St. Clair > >
