----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17077/#review32248 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/src/tests/http_tests.cpp <https://reviews.apache.org/r/17077/#comment60984> Is Some() necessary because we're going from a char* -> string -> Option<string> and so the implicit constructor is not working? Ditto elsewhere. - Ben Mahler On Jan. 17, 2014, 11:46 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17077/ > ----------------------------------------------------------- > > (Updated Jan. 17, 2014, 11:46 p.m.) > > > Review request for mesos, Benjamin Hindman and Charlie Carson. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/src/tests/http_tests.cpp c27e027 > > Diff: https://reviews.apache.org/r/17077/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
