----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17171/#review32500 -----------------------------------------------------------
Ship it! Sweet! src/zookeeper/group.hpp <https://reviews.apache.org/r/17171/#comment61361> Let's make this a static member of GroupProcess (which still has friend access to Membership) with a signature like 'std::string GroupProcess::znode(const Group::Membership& membership)' so that we can keep the implementation details private. src/zookeeper/zookeeper.hpp <https://reviews.apache.org/r/17171/#comment61359> Please fix indentation. src/zookeeper/zookeeper.hpp <https://reviews.apache.org/r/17171/#comment61360> Please fix indentation. - Benjamin Hindman On Jan. 22, 2014, 4:16 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17171/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2014, 4:16 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Brenden Matthews, and > Jiang Yan Xu. > > > Bugs: MESOS-903 > https://issues.apache.org/jira/browse/MESOS-903 > > > Repository: mesos-git > > > Description > ------- > > This updates the "Group" to create znodes with a label. > > This is part1 for MESOS-903. > > > Diffs > ----- > > src/tests/group_tests.cpp ac1942b10dd51b62ac36beac66a22d0aecdece89 > src/zookeeper/group.hpp 354229fe4f32d0d284e07819e7235edbea105c66 > src/zookeeper/group.cpp e21dc6f76f71bfe70bd83fa14d760f28c2cfa3d9 > src/zookeeper/zookeeper.hpp 1b4e2ed3f757bd73619034d39ef9c04942fe009c > > Diff: https://reviews.apache.org/r/17171/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
