----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17431/#review32932 -----------------------------------------------------------
src/webui/master/static/js/controllers.js <https://reviews.apache.org/r/17431/#comment61960> This should use the $location service instead of the global window.location. src/webui/master/static/js/controllers.js <https://reviews.apache.org/r/17431/#comment61961> Use the Angular $location API if possible instead of the global window.location: http://docs.angularjs.org/api/ng.$location src/webui/master/static/js/controllers.js <https://reviews.apache.org/r/17431/#comment61962> $location service here too instead of a global. - Ross Allen On Jan. 28, 2014, 12:53 a.m., Thomas Rampelberg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17431/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2014, 12:53 a.m.) > > > Review request for mesos and Ross Allen. > > > Bugs: mesos-885 > https://issues.apache.org/jira/browse/mesos-885 > > > Repository: mesos-git > > > Description > ------- > > Enabled configuration of the mesos master from the UI. > > Review: http://reviews.apache.org/r/17431 > > > Diffs > ----- > > src/Makefile.am d58b46e99e0a041cf2a26abe44bbd1504a9539c0 > src/webui/master/static/config.html PRE-CREATION > src/webui/master/static/css/mesos.css > 5b1227e9d64757f9fc106e497f7fa3ed72112c10 > src/webui/master/static/index.html f7f3d24abfee7d30691dbc2d7adf7c05c888a7b4 > src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803 > src/webui/master/static/js/controllers.js > afb24fb9c2184772f7314162f5637dbabaa2ab94 > > Diff: https://reviews.apache.org/r/17431/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > Config Dialog > > https://reviews.apache.org/media/uploaded/files/2014/01/28/5499d3e5-077e-4aff-b29a-7d32134f29a0__Screenshot_2014-01-27_16.53.12.png > > > Thanks, > > Thomas Rampelberg > >
