----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17442/#review32942 -----------------------------------------------------------
Ship it! Looks great! Thanks src/master/http.cpp <https://reviews.apache.org/r/17442/#comment61977> What are the "active" states besides RUNNING? STAGING and STARTING? Those should be fine to count too. Maybe add them to the comment to clarify. - Adam B On Jan. 27, 2014, 6:17 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17442/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2014, 6:17 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, David Robinson, and > Niklas Nielsen. > > > Bugs: MESOS-772 > https://issues.apache.org/jira/browse/MESOS-772 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > I opted for "active" tasks instead of "running" tasks because I didn't want > the stats endpoint to loop through all tasks to figure out if a task is in > RUNNING state. I think "active" is useful for most debugging purposes. > > > Diffs > ----- > > src/master/http.cpp 546e91dbb9c8ee1014bb4f0b3be2714ad6a2d520 > > Diff: https://reviews.apache.org/r/17442/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
