----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17481/#review33110 -----------------------------------------------------------
Ship it! src/slave/slave.cpp <https://reviews.apache.org/r/17481/#comment62386> Let's add a comment for our readers explaining why we need to use Time::create so people do this other places too! Also, what's the convention here for the '_'? You could just call it 'time' too. - Benjamin Hindman On Jan. 29, 2014, 3:39 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17481/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2014, 3:39 a.m.) > > > Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone. > > > Bugs: MESOS-952 > https://issues.apache.org/jira/browse/MESOS-952 > > > Repository: mesos-git > > > Description > ------- > > The slave was relying on a raw unix time stamp to compute garbage collection > times. > This is unreliable for testing purposes because we need to adjust the time > based on the libprocess clock. > > > Diffs > ----- > > src/slave/slave.cpp 8b83dacad802a5434bf76ca075b2b8113ed14a84 > > Diff: https://reviews.apache.org/r/17481/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
