----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17431/#review33161 -----------------------------------------------------------
src/webui/master/static/index.html <https://reviews.apache.org/r/17431/#comment62465> This can lead to an odd state, although it might be fine for now: 1. Open the config and set the host to something invalid like http://google.com 2. The alert displays, says "Failed to connect to google.com ..." 3. Click "set a new master" and delete the value, click "Save" After the modal closes, the alert now reads "Failed to connect to localhost:5050 ..." even though it hasn't tried to connect to it yet. Maybe the config modal could poll once on close if the master URL changed? This also might be too nuanced to be worth fixing. - Ross Allen On Jan. 28, 2014, 8:51 p.m., Thomas Rampelberg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17431/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2014, 8:51 p.m.) > > > Review request for mesos and Ross Allen. > > > Bugs: mesos-885 > https://issues.apache.org/jira/browse/mesos-885 > > > Repository: mesos-git > > > Description > ------- > > Enabled configuration of the mesos master from the UI. > > Review: http://reviews.apache.org/r/17431 > > > Diffs > ----- > > src/Makefile.am d58b46e99e0a041cf2a26abe44bbd1504a9539c0 > src/webui/master/static/config.html PRE-CREATION > src/webui/master/static/css/mesos.css > 5b1227e9d64757f9fc106e497f7fa3ed72112c10 > src/webui/master/static/directives/timestamp.html > 5e422b9f22f8ddaf987feec3e02a849f21e5e22c > src/webui/master/static/index.html f7f3d24abfee7d30691dbc2d7adf7c05c888a7b4 > src/webui/master/static/js/app.js 4ccff6314c684ae4e917345fe41a95ccc0eb5803 > src/webui/master/static/js/controllers.js > afb24fb9c2184772f7314162f5637dbabaa2ab94 > > Diff: https://reviews.apache.org/r/17431/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > Config Dialog > > https://reviews.apache.org/media/uploaded/files/2014/01/28/5499d3e5-077e-4aff-b29a-7d32134f29a0__Screenshot_2014-01-27_16.53.12.png > Connection Issue Alert > > https://reviews.apache.org/media/uploaded/files/2014/01/28/dee8df12-0bae-48b5-a7ce-c07e0266c790__Screenshot_2014-01-28_12.44.53.png > > > Thanks, > > Thomas Rampelberg > >
