----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17519/#review33188 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/17519/#comment62527> Can we wrap the body in another block? process->lock(); { foreach (Event* event, process->events) { ...; } } process->unlock(); - Benjamin Hindman On Jan. 30, 2014, 12:39 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17519/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2014, 12:39 a.m.) > > > Review request for mesos, Benjamin Hindman and Jie Yu. > > > Bugs: MESOS-954 > https://issues.apache.org/jira/browse/MESOS-954 > > > Repository: mesos-git > > > Description > ------- > > The process lock must be acquired before examining the event queue! > > > Diffs > ----- > > 3rdparty/libprocess/src/process.cpp > c28fc35e2fc2e5416691f52f2209e894d72e1c20 > > Diff: https://reviews.apache.org/r/17519/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
