----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16724/#review33187 -----------------------------------------------------------
Ship it! src/master/master.hpp <https://reviews.apache.org/r/16724/#comment62519> we tend to not add "_" suffixes to params in declarations. src/master/master.hpp <https://reviews.apache.org/r/16724/#comment62520> ditto src/master/master.hpp <https://reviews.apache.org/r/16724/#comment62521> ditto src/master/master.cpp <https://reviews.apache.org/r/16724/#comment62525> How about LOG(INFO) << "Re-add completed framework " << completedFramework_.framework_info().id() << " from slave " << slave-id << " (" << slave->info.hostname() << ")" ; src/master/master.cpp <https://reviews.apache.org/r/16724/#comment62526> s/Registering/Re-adding/ src/master/master.cpp <https://reviews.apache.org/r/16724/#comment62528> s/Registering/Re-adding/ src/slave/slave.cpp <https://reviews.apache.org/r/16724/#comment62522> why the different log level? s/2/1/? src/slave/slave.cpp <https://reviews.apache.org/r/16724/#comment62523> s/3/1/ src/slave/slave.cpp <https://reviews.apache.org/r/16724/#comment62524> s/3/1/ - Vinod Kone On Jan. 30, 2014, 12:17 a.m., Adam B wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16724/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2014, 12:17 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Niklas Nielsen, and > Vinod Kone. > > > Bugs: MESOS-767 > https://issues.apache.org/jira/browse/MESOS-767 > > > Repository: mesos-git > > > Description > ------- > > Added completed frameworks/tasks to slave re-registration. > Fixes MESOS-767. > > Additional issues discovered during investigation: > - MESOS-905: Remove Framework.id in favor of FrameworkInfo.id > - MESOS-906: Last task in Completed Framework never graduates from > terminatedTasks to completedTasks. > - Completed frameworks/executors/tasks are stored in circular buffers, > and these may overflow in different orders on different slaves. > BenH proposes an archive to replace these circular buffers. > > > Diffs > ----- > > src/master/master.hpp 7649737 > src/master/master.cpp 77872ec > src/messages/messages.proto 922a8c4 > src/slave/slave.cpp 2d21e16 > > Diff: https://reviews.apache.org/r/16724/diff/ > > > Testing > ------- > > make check; manually failed-over a master, watched the slave reregister its > completed frameworks, web UI shows completed tasks and stdout/stderr. > > > Thanks, > > Adam B > >
