----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17621/#review33370 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/17621/#comment62829> This promise does not seem "Owned" since we're binding it in multiple places, did you feel that since only one callback will operate on it, it is effectively "Owned"? - Ben Mahler On Jan. 31, 2014, 10:02 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17621/ > ----------------------------------------------------------- > > (Updated Jan. 31, 2014, 10:02 p.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/src/process.cpp > 1083a35a0fef48d5f790ec49305a56fd7ef451d5 > > Diff: https://reviews.apache.org/r/17621/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
