----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17663/#review33444 -----------------------------------------------------------
Ship it! - Ian Downes On Feb. 3, 2014, 5:50 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17663/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2014, 5:50 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > The local fields in cgroups and process isolator was uninitialized in > constructors and reported by Coverity: > > Defect(s) Reported-by: Coverity Scan > Showing 2 of 2 defect(s) > > > ** CID 1167299: Uninitialized scalar field (UNINIT_CTOR) > /src/slave/process_isolator.cpp: 71 in > mesos::internal::slave::ProcessIsolator::ProcessIsolator()() > > ** CID 1167300: Uninitialized scalar field (UNINIT_CTOR) > /src/slave/cgroups_isolator.cpp: 198 in > mesos::internal::slave::CgroupsIsolator::CgroupsIsolator()() > > Even though ::initialize() does set local, this patch should silence the code > scan. > > > Diffs > ----- > > src/slave/cgroups_isolator.cpp 690ae81 > src/slave/process_isolator.cpp 748d9c2 > > Diff: https://reviews.apache.org/r/17663/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Niklas Nielsen > >
