----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17574/#review33457 -----------------------------------------------------------
src/master/master.cpp <https://reviews.apache.org/r/17574/#comment62893> We are logging the generated `id` of "this" master. Maybe it's worthwhile to also log the leading master's `id` so that it helps debugging? - Jiang Yan Xu On Jan. 30, 2014, 5:04 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17574/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2014, 5:04 p.m.) > > > Review request for mesos, Benjamin Hindman, Brenden Matthews, Niklas Nielsen, > and Jiang Yan Xu. > > > Bugs: MESOS-422 and MESOS-672 > https://issues.apache.org/jira/browse/MESOS-422 > https://issues.apache.org/jira/browse/MESOS-672 > > > Repository: mesos-git > > > Description > ------- > > This is part 4. > > This is the meat of the fix for MESOS-672. > > As a bonus this also fixes, MESOS-422. > > > Diffs > ----- > > src/cli/resolve.cpp 0ebb0c65a2cb942fecda96a66b0ef013b64fdf6b > src/local/local.cpp 83a7f913afb1441e9137c7fcec8fd81815714905 > src/master/detector.hpp 277c9d907120a9ba30948d8ab4baaa2586293a62 > src/master/detector.cpp 2b169c551affe7acd2feac7806a27b46eb99bb88 > src/master/http.cpp fb15483953a593bfec4e60884219dc8c4e8d565c > src/master/main.cpp b1e45766281c5ea0b8a3cee89e390ea60a97c5e4 > src/master/master.hpp 7649737283f5f5d786ac40504e943a3be4c1d62b > src/master/master.cpp 77872ece66601043ddeb280cceba5a7676e8a6be > src/sched/sched.cpp 77588c398f0796ab6e4f24bbe805c204fd60753e > src/slave/slave.hpp 891c874397f5add9b70432c40c152f7f19922e34 > src/slave/slave.cpp a97b1d531d05e63e8ebaa474f526c110f5d573d4 > src/tests/balloon_framework_test.sh > bf92cd8a9e6b8e04d4ff8bd781a7f02c0ed87a58 > src/tests/cluster.hpp 065976c19170e995bd3766bcc7a9b0a244776108 > src/tests/master_contender_detector_tests.cpp > 5223200ee59b9ce0e1d228320e8ad9e84a567288 > > Diff: https://reviews.apache.org/r/17574/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
