----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17673/#review33539 -----------------------------------------------------------
Ship it! src/tests/slave_recovery_tests.cpp <https://reviews.apache.org/r/17673/#comment63060> s/_pid/pid/g - Benjamin Hindman On Feb. 3, 2014, 8:56 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17673/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2014, 8:56 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Bugs: MESOS-960 > https://issues.apache.org/jira/browse/MESOS-960 > > > Repository: mesos-git > > > Description > ------- > > Getting the pid file is a bit hacky, but it works for now. > > This is just one test I found contributing to MESOS-960, there may be more! > > > Diffs > ----- > > src/tests/slave_recovery_tests.cpp b8c5123fb91373eb4582b88bf54c4119f6a0212b > > Diff: https://reviews.apache.org/r/17673/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
