> On Feb. 1, 2014, 12:45 a.m., Benjamin Hindman wrote: > > src/common/protobuf_utils.hpp, line 105 > > <https://reviews.apache.org/r/17572/diff/1/?file=457210#file457210line105> > > > > Do you want to add any more randomness here? the MasterInfo created > > right now in master.cpp has the date information. At the very least I think > > a comment here describing that you're putting in arbitrary stuff to make up > > the ID would be great rather than getting people to expect that the ID == > > the PID.
Appended random uuid bits to pid here. I can't remember why I had to make it non-random. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17572/#review33376 ----------------------------------------------------------- On Jan. 31, 2014, 12:50 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17572/ > ----------------------------------------------------------- > > (Updated Jan. 31, 2014, 12:50 a.m.) > > > Review request for mesos, Benjamin Hindman, Brenden Matthews, Niklas Nielsen, > and Jiang Yan Xu. > > > Bugs: MESOS-672 > https://issues.apache.org/jira/browse/MESOS-672 > > > Repository: mesos-git > > > Description > ------- > > This is part 2. 'createMasterInfo()' is used in the subsequent reviews. > > > Diffs > ----- > > src/common/protobuf_utils.hpp c83cbd693abf87089288d03f01ce06200a5d9245 > src/common/type_utils.hpp fe6bf71d689f7bfd8b6ae1b8fab9b2e76e28e7a8 > > Diff: https://reviews.apache.org/r/17572/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
