----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17767/#review33852 -----------------------------------------------------------
src/log/tool/benchmark.cpp <https://reviews.apache.org/r/17767/#comment63470> Sorry for not catching this earlier, but can you make the log line more readable? output << "Time: " << timestamps[i] << " " << "Appended " << sizes[i].bytes() << " bytes " << "in " << durations[i].ms() << " ms" << endl; Also consider printing "timestamps[i]" as an epoch of seconds/milliseconds to make it easy to crunch this data. - Vinod Kone On Feb. 6, 2014, 10:07 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17767/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2014, 10:07 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > See summary. Currently, only type 'zero' and 'one' are supported. I will add > 'random' soon. > > > Diffs > ----- > > src/Makefile.am c307068 > src/log/main.cpp c37dd6f > src/log/tool/benchmark.hpp PRE-CREATION > src/log/tool/benchmark.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/17767/diff/ > > > Testing > ------- > > make check > > tested on command line. > > > Thanks, > > Jie Yu > >
