----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16909/#review33888 -----------------------------------------------------------
Ship it! Ship It! - Ben Mahler On Jan. 15, 2014, 11:04 p.m., Vinson Lee wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16909/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2014, 11:04 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Chi Zhang, Eric > Biederman, samya, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > From: Vinson Lee <[email protected]> > Date: Wed, 15 Jan 2014 09:31:04 -0800 > Subject: [PATCH] Require libc++ only on Mac OS X. > > This patch fixes configure failure on Linux clang builds. > > Signed-off-by: Vinson Lee <[email protected]> > > > Diffs > ----- > > configure.ac 9f96b7d > > Diff: https://reviews.apache.org/r/16909/diff/ > > > Testing > ------- > > On Linux: > $ ./bootstrap > $ ./configure > $ make > > configure now passes again. > > Linux clang build now fails at symbolize.cc. > src/symbolize.cc:235:58: error: invalid suffix on literal; C++11 requires a > space between literal and identifier [-Wreserved-user-defined-literal] > RAW_LOG(WARNING, "Section name '%s' is too long (%"PRIuS"); " > > > Thanks, > > Vinson Lee > >
