----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17686/#review33914 -----------------------------------------------------------
Can you give a high-level overview/description of what these changes accomplish? Best I can tell, now you can call discard on a promise itself, without having to go through to its future; plus s/onDiscarded/onDiscard/ and s/isDiscarded/hasDiscard/. Is there any functional difference beyond the renaming and syntactic sugar? src/java/jni/org_apache_mesos_state_AbstractState.cpp <https://reviews.apache.org/r/17686/#comment63669> Always false, no bothering to check the future? src/java/jni/org_apache_mesos_state_AbstractState.cpp <https://reviews.apache.org/r/17686/#comment63670> Ditto. At least a comment explaining src/java/jni/org_apache_mesos_state_AbstractState.cpp <https://reviews.apache.org/r/17686/#comment63671> Ditto src/sasl/authenticatee.hpp <https://reviews.apache.org/r/17686/#comment63674> Could future-observers have stopped caring before we bothered to do the sasl work above? - Adam B On Feb. 5, 2014, 3:41 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17686/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2014, 3:41 p.m.) > > > Review request for mesos, Adam B, Ben Mahler, Ian Downes, Jie Yu, Niklas > Nielsen, TILL TOENSHOFF, Vinod Kone, and Jiang Yan Xu. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/java/jni/org_apache_mesos_state_AbstractState.cpp > 2ee0b1b631b80ec783e6bce683cdeaa77e56b2aa > src/linux/cgroups.cpp 19ab1f348191ab0315271477b206aa8c6456fd5a > src/log/catchup.cpp 4ee32f285f77eb2de661e22a301b743bb8a06f9c > src/log/consensus.cpp b89673a3b8f233e901eaf9ae69a9979099f4eb73 > src/log/recover.cpp bb32e51e1172a8b32ac74be9848c1e72db5cefa0 > src/master/detector.cpp 2b169c551affe7acd2feac7806a27b46eb99bb88 > src/master/registrar.cpp 915885a160f790399e8185c28c6e6555af1ee76e > src/sasl/authenticatee.hpp f1a677f8aed0979f958e51f85e0a8210a03bd343 > src/sasl/authenticator.hpp 1478f6771b424555c34586a0d61f208dc15b0e7d > src/slave/gc.cpp 405350bf8f498d2e59e9e6b4c4c19b7bdaa974de > src/zookeeper/contender.cpp 6710da4e64fc0a43c1eabfc0f39fb0133c13df14 > src/zookeeper/group.cpp ecb6c002e8194b8d67e262826d988f747414f9f3 > > Diff: https://reviews.apache.org/r/17686/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
