----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17685/#review33970 -----------------------------------------------------------
3rdparty/libprocess/include/process/future.hpp <https://reviews.apache.org/r/17685/#comment63824> A comment here about the semantics would be rad. 3rdparty/libprocess/include/process/future.hpp <https://reviews.apache.org/r/17685/#comment63829> s/a/the/ ? 3rdparty/libprocess/include/process/future.hpp <https://reviews.apache.org/r/17685/#comment63841> Why are these static? 3rdparty/libprocess/include/process/future.hpp <https://reviews.apache.org/r/17685/#comment63840> Why did this ever not discard the underlying future? 3rdparty/libprocess/include/process/future.hpp <https://reviews.apache.org/r/17685/#comment63843> I'm a bit confused. When you say "shouldn't get called" is the onus on the user to not call it or do we programmatically prevent it? In other words, can we a use a boolean "associated" to enforce the semantics? also, s/promises/promise's/ 3rdparty/libprocess/include/process/future.hpp <https://reviews.apache.org/r/17685/#comment63867> +1 3rdparty/libprocess/include/process/future.hpp <https://reviews.apache.org/r/17685/#comment63872> curious why you need "typename" here? 3rdparty/libprocess/include/process/future.hpp <https://reviews.apache.org/r/17685/#comment63903> How about result = data->discard = !data->discard && data->state == PENDING; Is that too complicated? 3rdparty/libprocess/src/tests/io_tests.cpp <https://reviews.apache.org/r/17685/#comment63912> Is the assumption here that that the pipe buffer size is definitely greater than 128 bytes? 3rdparty/libprocess/src/tests/process_tests.cpp <https://reviews.apache.org/r/17685/#comment63913> why await? is the future not discarded synchronously? 3rdparty/libprocess/src/tests/process_tests.cpp <https://reviews.apache.org/r/17685/#comment63914> ASSERT on the return value? - Vinod Kone On Feb. 5, 2014, 11:40 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17685/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2014, 11:40 p.m.) > > > Review request for mesos, Adam B, Ben Mahler, Ian Downes, Jie Yu, Niklas > Nielsen, TILL TOENSHOFF, Vinod Kone, and Jiang Yan Xu. > > > Repository: mesos-git > > > Description > ------- > > Previously, invoking Future::discard caused a future to transition > into the DISCARDED state which meant that any callbacks associated wit > such a transition (i.e., Future::onAny, Future::onDiscarded) got > executed _even if the computation associated with the future had not > yet completed_! This meant certain patterns where difficult if not all > together impossible. Consider: > > ExpensiveResource* resource = new ExpensiveResource(); > > Future<int> future = function() > .then([=] () { ... *resource ...; }) > .onDiscarded([=] () { delete resource; }); > > future.discard(); > > In the above code, it's possible that the onDiscarded lambda would > execute _concurrently_ with the lambda in the then! With the new > semantics, a discard is more advisorial: rather than transition a > future it instead allows a subsequent computation to decide whether or > not to cancel (or even begin) some computation. For example, the > Future::then implementation uses the "discard" information to decide > whether or not to execute the next lambda after the previous future > has been satisfied. > > A few new helpers have been added to support this refactor: > > Future::onDiscard(callback): > > Adds a callback for when Future::discard was executed on this future. > > Future::hasDiscard(): > > Checks to see if Future::discard was executed on this future. > > Promise::discard(): > > Transitions this promises underlying future to DISCARDED. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/tests/os/signals_tests.cpp > 66caa0490189cb1aff3af1631fbcf7150658b6cc > 3rdparty/libprocess/include/process/collect.hpp > ff8ab341a588d26f9678aea7f53e892d292725ec > 3rdparty/libprocess/include/process/deferred.hpp > a25080f7cfc164108e89660d4c38de8b290aee02 > 3rdparty/libprocess/include/process/future.hpp > aaf17af2eef0f1bf7062aa04469f1fa27bb4cfbe > 3rdparty/libprocess/include/process/protobuf.hpp > 7500601026a58c95325ffe4410a161d59ff7817e > 3rdparty/libprocess/src/process.cpp > 2e7764a8e0badec704b8610f3f72f0bd16cc9612 > 3rdparty/libprocess/src/tests/http_tests.cpp > 62ab64d81c11ab7260620c91100b7e1f29b81e33 > 3rdparty/libprocess/src/tests/io_tests.cpp > eab786432debf06615572c4486cdf08bac91d927 > 3rdparty/libprocess/src/tests/process_tests.cpp > be288c353dce78ef641708646979e2e4f3f2c504 > > Diff: https://reviews.apache.org/r/17685/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
