----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15853/#review34671 -----------------------------------------------------------
Ship it! Looks good to me. Would this also be a problem for the ExecutorDriver/Executor? src/sched/sched.cpp <https://reviews.apache.org/r/15853/#comment64882> Why have both data structures here? The circular_buffer to track the oldest message and the hashset for fast contains(x) lookups? It does seem like there should be a better way. - Adam B On Feb. 14, 2014, 2:28 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15853/ > ----------------------------------------------------------- > > (Updated Feb. 14, 2014, 2:28 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-551 > https://issues.apache.org/jira/browse/MESOS-551 > > > Repository: mesos-git > > > Description > ------- > > Couldn't update the review at https://reviews.apache.org/r/12603/ :( > > So creating a new one. > > > Diffs > ----- > > src/sched/sched.cpp dcb3158d2acd93a107fda51b19e92899a092e628 > src/tests/status_update_manager_tests.cpp > 07aa2ce330be8fa8772cb5fed06d004532275d92 > > Diff: https://reviews.apache.org/r/15853/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
