----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18204/#review34709 -----------------------------------------------------------
3rdparty/libprocess/include/process/future.hpp <https://reviews.apache.org/r/18204/#comment64920> it's good practice to define != in terms of ==. Ie, this would be: return !(*this == that); - Dominic Hamon On Feb. 18, 2014, 12:44 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18204/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2014, 12:44 a.m.) > > > Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/future.hpp > aaf17af2eef0f1bf7062aa04469f1fa27bb4cfbe > > Diff: https://reviews.apache.org/r/18204/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
