> On Feb. 18, 2014, 10:25 a.m., Vinod Kone wrote: > > src/common/http.cpp, lines 17-18 > > <https://reviews.apache.org/r/18144/diff/2-3/?file=486407#file486407line17> > > > > How about? > > > > JSON::Object& role = roles[resource.role()]; > > > > and inside the switch > > > > role.values[resource.name()] = ... > > > > > > Ben Mahler wrote: > Vinod, please see the similar discussion in: > https://reviews.apache.org/r/17976/
I had this in MESOS-692 but was asked to replace the non-const reference with lookups within the case statements. - Dominic ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18144/#review34721 ----------------------------------------------------------- On Feb. 18, 2014, 11:41 a.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18144/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2014, 11:41 a.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-990 > https://issues.apache.org/jira/browse/MESOS-990 > > > Repository: mesos-git > > > Description > ------- > > See summary > > > Diffs > ----- > > src/Makefile.am c30706846bca1fa3287291e39f46a23713ad1ba4 > src/common/http.hpp PRE-CREATION > src/common/http.cpp PRE-CREATION > src/master/http.cpp 966eed6d8340038265ef799f1b6149502ccc606e > src/slave/http.cpp c4f598faf6807214608cc89a6d9cf665133f95f3 > > Diff: https://reviews.apache.org/r/18144/diff/ > > > Testing > ------- > > make check. > > ran master/slave and checked http://localhost:5050/master/state.json by eye. > > > Thanks, > > Dominic Hamon > >
