> On Feb. 19, 2014, 1:39 a.m., Ben Mahler wrote: > > src/log/leveldb.cpp, lines 338-342 > > <https://reviews.apache.org/r/18252/diff/2/?file=497324#file497324line338> > > > > You're updating first _before_ checking status.ok(), what are the > > consequences of that? > > Jie Yu wrote: > Good catch!
Great catch Ben, I should have caught that too, my apologies. > On Feb. 19, 2014, 1:39 a.m., Ben Mahler wrote: > > src/log/leveldb.cpp, line 377 > > <https://reviews.apache.org/r/18252/diff/2/?file=497324#file497324line377> > > > > CHECK_SOME :) As should I have caught this one! I reviewed this too quickly. :( - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18252/#review34824 ----------------------------------------------------------- On Feb. 19, 2014, 2:24 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18252/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2014, 2:24 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-1014 > https://issues.apache.org/jira/browse/MESOS-1014 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/log/leveldb.hpp 7eb51be > src/log/leveldb.cpp 7819963 > > Diff: https://reviews.apache.org/r/18252/diff/ > > > Testing > ------- > > make check > > Will follow up with more tests on logs with large index. > > > Thanks, > > Jie Yu > >
