----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15099/#review34844 -----------------------------------------------------------
Ship it! src/master/registrar.cpp <https://reviews.apache.org/r/15099/#comment65243> Let's not expose this as a CHECK as it's making a contract with a caller that is rather hard to track down. How about RegistrarProcess::admit returns a Failure if 'info.has_id()' is false? And let's also add a comment on Registrar::admit that makes it clear that the SlaveInfo is expected to have 'id' set. - Benjamin Hindman On Feb. 15, 2014, 12:57 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15099/ > ----------------------------------------------------------- > > (Updated Feb. 15, 2014, 12:57 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Bugs: MESOS-764 > https://issues.apache.org/jira/browse/MESOS-764 > > > Repository: mesos-git > > > Description > ------- > > This is addressing my comments on https://reviews.apache.org/r/14383/ > > There was also a bug fix in the removal mutation. > > > Diffs > ----- > > src/master/registrar.hpp 5742c365bac0082efea53c35333d3c3503494066 > src/master/registrar.cpp 915885a160f790399e8185c28c6e6555af1ee76e > src/master/registry.proto bd850997c57153cdfc0c39d0dae7d2b802034aa3 > src/tests/registrar_tests.cpp 51975f5aa2725f64d2a83387a381e5078c8b9e1d > > Diff: https://reviews.apache.org/r/15099/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
