> On Jan. 27, 2014, 7:08 p.m., Jie Yu wrote: > > src/java/jni/org_apache_mesos_Log.cpp, line 341 > > <https://reviews.apache.org/r/17346/diff/1/?file=450724#file450724line341> > > > > Shouldn't be: > > > > position.get().get()?
For posterity, this actually compiles and links but is completely broken unless 'convert<Log::Position>' is used (like in the rest of this file). - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17346/#review32858 ----------------------------------------------------------- On Feb. 19, 2014, 8:04 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17346/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2014, 8:04 a.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/java/jni/org_apache_mesos_Log.cpp > 36c636d155c1581eeb7734cdbc5b6fac4ca42440 > src/log/log.cpp e83f822af86a2389e2b1abab9489713cb59838c2 > src/tests/log_tests.cpp 7e6dbdee0a9b316e49fda5fd36a9f76331265a24 > > Diff: https://reviews.apache.org/r/17346/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
