----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18261/#review34872 -----------------------------------------------------------
src/tests/log_tests.cpp <https://reviews.apache.org/r/18261/#comment65255> Consider setting all these constants as named constants. Ie, kTruncatePosition, kEndAppendPosition, etc. src/tests/log_tests.cpp <https://reviews.apache.org/r/18261/#comment65256> Consider adding a benchmark to measure the time taken for this, and maybe to check for regressions. - Dominic Hamon On Feb. 18, 2014, 10:29 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18261/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2014, 10:29 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-1014 > https://issues.apache.org/jira/browse/MESOS-1014 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/Makefile.am 768c66a > src/log/leveldb.cpp 7819963 > src/tests/log_tests.cpp 7e6dbde > > Diff: https://reviews.apache.org/r/18261/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
