----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18276/#review34905 -----------------------------------------------------------
src/tests/isolator_tests.cpp <https://reviews.apache.org/r/18276/#comment65288> You want to do this temp directory creation and cleanup in SetUp/TearDown of LimitedCpuIsolatorTest fixture. This ensures that if the test fails the directory is not leaked. src/tests/isolator_tests.cpp <https://reviews.apache.org/r/18276/#comment65290> It is unfortunate that this test takes 2s. Can we bring this time down? src/tests/isolator_tests.cpp <https://reviews.apache.org/r/18276/#comment65289> move this to TearDown of the fixture. - Vinod Kone On Feb. 19, 2014, 6:53 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18276/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2014, 6:53 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Runs a single core cpu bound process for 1 second but limited to 0.25 cpu and > ensures 0.20 <= system + user cpu time <= 0.30. > > > Diffs > ----- > > src/tests/isolator_tests.cpp 9ec285a0da95d2b610037ad3c82e759b8d3bdbd8 > > Diff: https://reviews.apache.org/r/18276/diff/ > > > Testing > ------- > > make check # Linux > > > Thanks, > > Ian Downes > >
