----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17686/#review34956 -----------------------------------------------------------
Ship it! Modulo the internal::discard and catchup timeouts comments from jie. - Ben Mahler On Feb. 18, 2014, 8:46 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17686/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2014, 8:46 a.m.) > > > Review request for mesos, Adam B, Ben Mahler, Ian Downes, Jie Yu, Niklas > Nielsen, TILL TOENSHOFF, Vinod Kone, and Jiang Yan Xu. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/java/jni/org_apache_mesos_state_AbstractState.cpp > 2ee0b1b631b80ec783e6bce683cdeaa77e56b2aa > src/linux/cgroups.cpp 8ac25993886f5092fe6a58abdddbbb71e02911af > src/log/catchup.cpp 59facbf9b5d065ba5066b6b443db4ee8e05ee33b > src/log/consensus.cpp b89673a3b8f233e901eaf9ae69a9979099f4eb73 > src/log/log.cpp e83f822af86a2389e2b1abab9489713cb59838c2 > src/log/recover.cpp d06e5ada714ba0e5359ff1d3381edb6d526c6ad3 > src/master/detector.cpp 7e10433013b9415ec73c388e8dc69ab0989cdbc2 > src/master/registrar.cpp 915885a160f790399e8185c28c6e6555af1ee76e > src/sasl/authenticatee.hpp f1a677f8aed0979f958e51f85e0a8210a03bd343 > src/sasl/authenticator.hpp 1478f6771b424555c34586a0d61f208dc15b0e7d > src/slave/gc.hpp 328aa315d8ebd7ea5d05b57626ea4dbfc2206270 > src/slave/gc.cpp 405350bf8f498d2e59e9e6b4c4c19b7bdaa974de > src/zookeeper/contender.cpp 6710da4e64fc0a43c1eabfc0f39fb0133c13df14 > src/zookeeper/group.cpp 793763e8312676f3b7cceb54bbad0337c8445ea7 > > Diff: https://reviews.apache.org/r/17686/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
