Ah good to see Jake's comment. Thanks for taking the next steps, looking forward to this!
On Thu, Feb 20, 2014 at 12:02 PM, Dave Lester <[email protected]>wrote: > On Thu, Feb 20, 2014 at 10:53 AM, Benjamin Mahler < > [email protected]> wrote: > >> I would really like to see this in action before we start having bringing >> people through the process. Can you please send some trivial pull requests, >> with and without JIRA tickets? >> > > I've generated a pull request to test this, and will closing a PR with my > commit shortly; the only missing piece is that we need the list moderator > to approve the two email addresses in this issue: > https://issues.apache.org/jira/browse/INFRA-7350 > > >> I want to make sure they can be closed and we don't further the mess in >> https://github.com/apache/mesos/pulls by leaving more and more pull >> requests open. >> > > Looks like JakeF's message is currently in moderation, but here's what he > wrote on closing new issues: > > "You can comment on open pull requests using GitHubs web interface or use > ASFbot, `/msg ASFBot help github` github(3): reply [project] [pr-id] > [message] Comments on a specific GitHub Pull Request. For instance: github > reply couchdb 1 Thanks!!. > > You can close open pull requests on the Apache GitHub mirrors by adding to > the commit message closes #2 or fixes #5, see [1] for more details." > > Additionally, he said on IRC that they are working on making it possible > for folks to close irrelevant PRs through a similar mechanism without a > commit, although for now the solution is to ask the author to close it > themselves or ask Apache INFRA to close it. > > >> Also, closing the existing ones would be great. >> > > Shout-out to Jake Farrell for doing this! > https://github.com/apache/mesos/pulls?direction=desc&page=1&sort=created&state=closed > I've > also left comments on these PRs to thank and notify folks. > > >> But weren't you just saying that some of these would be trivial changes >> to documentation? We certainly should not be making a JIRA ticket for every >> typo in a document, how will this process work with pull requests without >> JIRA tickets? >> > > By most changes, I meant code changes that go beyond changing a basic > variable or two. Non-code changes like documentation or comments shouldn't > need JIRA issues. > > Some Apache projects actually do reviews this way! ;) >> Ex: https://issues.apache.org/jira/browse/HADOOP-9909 >> > > True, but I think we agree that such a system makes reviewing very > difficult. > > Dave >
