----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18144/#review35124 -----------------------------------------------------------
Ship it! Ok great! src/common/http.cpp <https://reviews.apache.org/r/18144/#comment65535> Let's avoid committing commented out code, since we have the history in ReviewBoard and your local git repository has the code in its history as well. - Ben Mahler On Feb. 21, 2014, 12:29 a.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18144/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2014, 12:29 a.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-692 and MESOS-990 > https://issues.apache.org/jira/browse/MESOS-692 > https://issues.apache.org/jira/browse/MESOS-990 > > > Repository: mesos-git > > > Description > ------- > > See summary > > > Diffs > ----- > > src/Makefile.am e02d416e5cb8edf6c44ed05c5785a5084bf02abb > src/common/http.hpp PRE-CREATION > src/common/http.cpp PRE-CREATION > src/master/http.cpp c9412749baeb88e8fc270eeca8710f04da2ac076 > src/slave/http.cpp 7c4cfba6676124926cfaa665df9fccf68c7dc187 > > Diff: https://reviews.apache.org/r/18144/diff/ > > > Testing > ------- > > make check. > > ran master/slave and checked http://localhost:5050/master/state.json by eye. > > ran local/python test framework and watched webui main, framework, and slave > pages. > > > Thanks, > > Dominic Hamon > >
