----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18361/#review35254 -----------------------------------------------------------
Attach the bug id to the RB's "Bug" field. include/mesos/mesos.proto <https://reviews.apache.org/r/18361/#comment65716> Please wrap the comments by 70 chars. include/mesos/mesos.proto <https://reviews.apache.org/r/18361/#comment65717> Lets do this in the similar vein of "user" field, i.e., only automagically set it if it's not set by the framework. kill white space. src/sched/sched.cpp <https://reviews.apache.org/r/18361/#comment65718> Only set this if the framework hasn't set it already. src/sched/sched.cpp <https://reviews.apache.org/r/18361/#comment65719> New line. - Vinod Kone On Feb. 24, 2014, 4:11 a.m., Bernd Mathiske wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18361/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2014, 4:11 a.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > - Added a field to FrameworkInfo in protobuf spec > - Added table fields in html of web ui that display framework's hostname for > running and terminated frameworks > - Added line to scheduler constructor that sets framework hostname. This is > just about the first centralized piece of code that every framework executes. > - Refactored scheduler constructor so that code duplication is avoided. > > > Diffs > ----- > > include/mesos/mesos.proto 69a4a60 > include/mesos/scheduler.hpp 2e4707e > src/master/http.cpp c941274 > src/sched/sched.cpp dcb3158 > src/slave/http.cpp 7c4cfba > src/webui/master/static/frameworks.html 8686b00 > > Diff: https://reviews.apache.org/r/18361/diff/ > > > Testing > ------- > > Built (with Clang) and ran local Mesos on Mac. Ran C++ and Java test > frameworks. Observed new hostname display in web UI. Built Mesos on Ubuntu > 13.10 with gcc 4.8.1. > > > Thanks, > > Bernd Mathiske > >
